International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

More updates needed to Template Info file #14

Closed jb388 closed 6 years ago

jb388 commented 6 years ago

I noticed there are a few more errors in the template info file that need to be fixed, e.g. site elevation range should be from -413 to 8900, latitude range should be from -90 to 90, not -180 to 180, etc.

I will go over the template info file and make a pull request once I have reviewed it.

jb388 commented 6 years ago

@greymonroe: Some of the fields that we marked as required in the Template Info file are intended to allow blanks, for example, no data in the "pro_treatment" field is interpreted to mean "control". How should do we accommodate blanks, from a QAQC perspective? Should we put "NA" as one of the controlled vocabulary options in the "Vocab" field of the Template Info file?

greymonroe commented 6 years ago

If blank values are acceptable, it should not be required.

jb388 commented 6 years ago

Yes, that makes sense. I am updating the Template Info file accordingly. But for non-required variables with controlled vocabulary can you confirm the appropriate syntax for allowable null values in controlled vocabulary fields? E.g. based on the Template Info file, the convention has been to use "or blank", so I just wanted to confirm that the QAQC function can parse that.

jb388 commented 6 years ago

Master Template/Template Info file status: I updated many of the acceptable value ranges as well as some controlled vocabulary for the non-required fields in the template info file. I also updated all of the observation date columns in both the Master Template and the Template Info files from a singular date field to three numeric fields (yyyy, mm, dd). I changed the value in the "Required" field of the Template Info file to "Yes" for the year columns in the flux, layer, and interstitial tables, but set the value to "No" for all other observation date columns.

I am currently in the process of updating the MPI and Powell Center templates accordingly. @greymonroe : can you incorporate this change when you convert Yujie's templates to the new Master Template format?

greymonroe commented 6 years ago

All of this sounds good. But there is only one template for ISRaD (not divided between MPI and Powell Center).

greymonroe commented 6 years ago

"or blank" should not be included in the controlled vocab

jb388 commented 6 years ago

Yes, I know there's only one Master Template---I meant the entries completed by the respective groups.

jb388 commented 6 years ago

Thanks for clarifying the "or blank" syntax.

greymonroe commented 6 years ago

Yes, I know there's only one Master Template---I meant the entries completed by the respective groups.

Ah ok sounds great.

jb388 commented 6 years ago

Up-to-date Master Template and Template Info files uploaded. See pull request.

greymonroe commented 6 years ago

ok, i accepted the pull request and will go ahead and close this issue