International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

Error while creating the ISRaD_extra object #173

Closed mguderle closed 5 years ago

mguderle commented 5 years ago

Hi all,

while running the ISRaD.build function, I get the following error when the code tries to create the ISRaD_extra object:

Creating the ISRaD_extra object... Error in $<-.data.frame(*tmp*, "lyr_dd14c", value = c(-172.4, -330.4, : replacement has 7101 rows, data has 7029 In addition: Warning message: In database$layer$lyr_14c - calc_atm14c(database$layer, "lyr_obs_date_y")$atm14C : longer object length is not a multiple of shorter object length

I used the current version and also updated all packages.

Would be happy for some hints/help.

Best, Marcus

greymonroe commented 5 years ago

Hey Marcus, I was unable to replicate the error. I have the most up to date version. Did this error occur when trying to add a new dataset?

mguderle commented 5 years ago

Hey Grey, yes it occurred while adding 1 new datasets, which I attached Hall_2015_2018.xlsx

Corey combined two datasets (https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/167). It got a positive QA/QC output.

Corey and Grey, could you please check the template and change it if necessary?

Thanks!

greymonroe commented 5 years ago

Can you send me the two datasets? I will see if I can get the same error

On Feb 26, 2019, at 1:15 AM, mguderle notifications@github.com wrote:

Hey Grey, yes it occurred while adding 2 new datasets. Do you have an idea what went wrong?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

coreylawrence commented 5 years ago

The problematic dataset is linked in Marcus's post above. I had another look at the file, which passes qa/qc and don't see any immediate red flags. I'm guessing the issue derives from the fill extra function but may be triggered by something in this template. One possibility is the inclusion of two listings in the metadata table, the second of which is not referenced at any other level.

greymonroe commented 5 years ago

I think the issue is because there is already Hall_2015 in the data files. Are these redundant?

coreylawrence commented 5 years ago

Yes, the Hall_2015_2018.xls template is the original Hall_2015 template merged with some additional data reported in a separate publication. The Hall_2015 should be replaced by the new one.

greymonroe commented 5 years ago

Ok great. Yes, removing Hall_2015.xlsx fixes the error.

On Feb 28, 2019, at 10:07 AM, Corey Lawrence notifications@github.com wrote:

Yes, the Hall_2015_2018.xls template is the original Hall_2015 template merged with some additional data reported in a separate publication. The Hall_2015 should be replaced by the new one.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/173#issuecomment-468307220, or mute the thread https://github.com/notifications/unsubscribe-auth/AP5w_AG7pK1rMkjkHgxh7XR1NfqkAqn0ks5vR_ChgaJpZM4bPnGU.