search

International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

'ISRaD_data' is not an exported object from 'namespace:ISRaD' #193

Closed jb388 closed 5 years ago

jb388 commented 5 years ago

@greymonroe I pulled the requireNamespace calls to the 'SoilR' and 'forecast' packages, since we decided to get rid of the predicted atmospheric 14C (forecasted data look terrible).

When I tried to run the devtools::document function on the ISRaD directory to update the DESCRIPTION and NAMESPACE files, I got the following error:

Error: 'ISRaD_data' is not an exported object from 'namespace:ISRaD'

I think this means we need to get rid of the .R files that corresponded to the (now absent) data objects, correct?

Edit: I removed them and seems to work. But is there any reason to keep them?

greymonroe commented 5 years ago

Exactly, yes we should delete those.

On Jun 22, 2019, at 6:27 PM, Jeff B notifications@github.com wrote:

@greymonroe https://github.com/greymonroe I pulled the requireNamespace calls to the 'SoilR' and 'forecast' packages, since we decided to get rid of the predicted atmospheric 14C (forecasted data look terrible).

When I tried to run the devtools::document function on the ISRaD directory to update the DESCRIPTION and NAMESPACE files, I got the following error:

Error: 'ISRaD_data' is not an exported object from 'namespace:ISRaD'

I think this means we need to get rid of the .R files that corresponded to the (now absent) data objects, correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/193?email_source=notifications&email_token=AD7HB7CQNHO4QLXUGV7CE6DP3ZHH5A5CNFSM4H2XEEWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3DIIDA, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7HB7DS7WIYWHMMSNUQA5TP3ZHH5ANCNFSM4H2XEEWA.

jb388 commented 5 years ago

OK, I'll push my changes.

greymonroe commented 5 years ago

Are you going to delete them? I can too just let me know

On Jun 22, 2019, at 6:29 PM, Grey Monroe greymonroe@gmail.com wrote:

Exactly, yes we should delete those.

On Jun 22, 2019, at 6:27 PM, Jeff B <notifications@github.com mailto:notifications@github.com> wrote:

@greymonroe https://github.com/greymonroe I pulled the requireNamespace calls to the 'SoilR' and 'forecast' packages, since we decided to get rid of the predicted atmospheric 14C (forecasted data look terrible).

When I tried to run the devtools::document function on the ISRaD directory to update the DESCRIPTION and NAMESPACE files, I got the following error:

Error: 'ISRaD_data' is not an exported object from 'namespace:ISRaD'

I think this means we need to get rid of the .R files that corresponded to the (now absent) data objects, correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/193?email_source=notifications&email_token=AD7HB7CQNHO4QLXUGV7CE6DP3ZHH5A5CNFSM4H2XEEWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3DIIDA, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7HB7DS7WIYWHMMSNUQA5TP3ZHH5ANCNFSM4H2XEEWA.

jb388 commented 5 years ago

yes, I deleted them