International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

Duplicate copies of data objects and files #194

Closed jb388 closed 4 years ago

jb388 commented 5 years ago

@greymonroe The build function creates duplicate copies of the ISRaD data objects and files: one set is in the directory "ISRaD_directory/ISRaD_data_files/database", the other set is in the directory inside that one, "ISRaD_data_files/database/ISRaD_database_files".

Do we need to have both?

Edit: Is it because the files need to be written first and then zipped?

greymonroe commented 5 years ago

Good observation. I think they both exist for a reason. The ones in "ISRaD_Directory/ISRaD_data_files/database” don’t have the version extension, which is needed for functions that call those objects. Though I must admit I can’t remember where this is actually used. Can you think of anything? Im looking through scripts for cases where those are needed.

On Jun 22, 2019, at 8:48 PM, Jeff B notifications@github.com wrote:

@greymonroe https://github.com/greymonroe The build function creates duplicate copies of the ISRaD data objects and files: one set is in the directory "ISRaD_directory/ISRaD_data_files/database", the other set is in the directory inside that one, "ISRaD_data_files/database/ISRaD_database_files".

Do we need to have both?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/194?email_source=notifications&email_token=AD7HB7ES6OKZK4I4ACC3N43P3ZXWLA5CNFSM4H2XLUFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3DNXXQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7HB7H5ZVE5DDHJZ6GNCKDP3ZXWLANCNFSM4H2XLUFA.

jb388 commented 5 years ago

As far as I know, none of the scripts explicitly reference the version extension. If we do discover that the duplication is unnecessary, I would be in favor of keeping those with the version extension.

greymonroe commented 5 years ago

Right, none reference the ones with version number because that would be difficult to implement (you would have to update the code every time a new version was created), which is why I thought we had kept the ones without version in the name. In any case, I agree with you. If they are unnecessary we should just keep those in the ISRaD_database_files https://github.com/International-Soil-Radiocarbon-Database/ISRaD/tree/master/ISRaD_data_files/database/ISRaD_database_files folder with version names

On Jun 22, 2019, at 9:45 PM, Jeff B notifications@github.com wrote:

As far as I know, none of the scripts explicitly reference the version extension. If we do discover that the duplication is unnecessary, I would be in favor of keeping those with the version extension.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/194?email_source=notifications&email_token=AD7HB7BFB7OFFVZKLPGYCD3P3Z6NFA5CNFSM4H2XLUFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKQEOI#issuecomment-504693305, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7HB7EMOBGG47CSCF26OTTP3Z6NFANCNFSM4H2XLUFA.