Code robustness and clarity

International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools

24 stars 15 forks source link

Closed bpbond closed 4 years ago

bpbond commented 4 years ago

Hi folks, a few code suggestions, use or not as you see fit:

seq_len() and seq_along() are much less prone to problems involving 1:length(...)
TRUE and FALSE are reserved keywords in R, while T and F are not, so it's safer (and clearer) to use the former
if(x == TRUE) is slower and less clear (imho) than simply if(x)

Note: I haven't tried running the code with these changes, so please test!

jb388 commented 4 years ago

@bpbond Great! Thanks for the helpful contributions. Improvements to the code are always welcome.