International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

Consider applying a consistent, clear code style #216

Closed bpbond closed 4 years ago

bpbond commented 4 years ago

This is a big, invasive PR touching all code files, so you may or may not want to merge. I'm opening it mostly to show the advantages of running the ISRaD code through something like the styler package, which formats everything to conform to a particular code style. (I've used the default tidyverse style, but there are others.)

To my eye, the gains in consistency (in e.g. spacing) and clarity are significant, as I find parts of the current codebase hard to read, but ymmv. Thanks!

jb388 commented 4 years ago

@bpbond Wow, this is great. I've been incrementally working on making the code stylistically consistent, but it's a real pain to do manually, so haven't gotten too far. I'll wait til the travis build finishes before accepting the pull request (assuming no errors), but after a quick scan I found nothing problematic.