International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

Duplicate record QAQC for unique ID fields #55

Closed jb388 closed 6 years ago

jb388 commented 6 years ago

Since we added unique ids (xxx_name fields) to the flux, incubation, and interstitial tables, it seems reasonable to add a couple lines to QAQC to check for duplicate entries---which should not be allowed. This should enable us to keep track of replicates better at their respective spatial/temporal scales. Thoughts?

greymonroe commented 6 years ago

Sounds good, we could define duplicates as identical rows or those with the same identifiers. Which do you think?

On Sep 27, 2018, at 11:16 AM, Jeff B notifications@github.com wrote:

Since we added unique ids (xxx_name fields) to the flux, incubation, and interstitial tables, it seems reasonable to add a couple lines to QAQC to check for duplicate entries---which should not be allowed. This should enable us to keep track of replicates better at their respective spatial/temporal scales. Thoughts?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/International-Soil-Radiocarbon-Database/ISRaD/issues/55, or mute the thread https://github.com/notifications/unsubscribe-auth/AP5w_BnqnbWg--9rYsVzNfBUeO8udFFwks5ufOvCgaJpZM4W84-v.

jb388 commented 6 years ago

I would use the identifiers (xxx_name). My thought is that people may enter reps with the same name, so they may have different values in some of the other fields.

jb388 commented 6 years ago

Started implementing some of this, but had some issues. Code worked fine in R (used it to find and remove all fraction and some layer duplicates), but when implemented in QAQC I ran into issues. Left placeholder code in the QAQC script, but commented it out.

greymonroe commented 6 years ago

@jb388 can you specify the line numbers where this is found in the current QAQC function code

jb388 commented 6 years ago

229:234, 284:290, 339:344, 392:398, 459:471, 531:537

I can also work on this---I suspect this is an easy fix.

greymonroe commented 6 years ago

sounds great

greymonroe commented 6 years ago

Looks like this has been completed