search

International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

DOI check slow/inconsistent #63

Closed jb388 closed 5 years ago

jb388 commented 5 years ago

The DOI check in the QAQC is very slow. Additionally, it sometimes fails with DOIs that have passed in the past. I propose that we consider making the DOI check an optional component of the QAQC, which we would set to FALSE for the compile function.

Since data can only be ingested into ISRaD by a member of the ISRaD team, we could run the DOI check for datasets separately before we ingest to make sure they work.

ShaneStoner commented 5 years ago

I have had this thought as well. Makes sense to me. I think the web tool QAQC should always check DOI, though.

jb388 commented 5 years ago

Agreed. Good call, Shane!

jb388 commented 5 years ago

Is there anyway to set this parameter to FALSE when compiling? More efficient for development.

greymonroe commented 5 years ago

fixed in last commit