search

InternationalColorConsortium / DemoIccMAX

Demonstration Implementation for iccMAX color profiles
Other
121 stars 37 forks source link

Fix wxstring conversion and include issues #107

Closed maxderhak closed 17 hours ago

maxderhak commented 2 days ago

further work to fix dependency on nlohmann json for moder c++ is still needed for cmake builds. The following might be helpful (beyond me). https://github.com/nlohmann/json?tab=readme-ov-file#integration

xsscx commented 1 day ago

Fixups for JSON Integration

Based on PR-107 there were changes needed to compile these projects, see PR https://github.com/InternationalColorConsortium/DemoIccMAX/pull/108

Source: https://github.com/xsscx/PatchIccMAX/tree/json-patches

    modified:   Readme.md
        modified:   Build/Cmake/CMakeLists.txt
    new file:   Tools/CmdLine/IccApplyNamedCmm/CMakeLists.txt
    new file:   Tools/CmdLine/IccApplyProfiles/CMakeLists.txt
    modified:   Tools/CmdLine/IccCommon/IccCmmConfig.h
    modified:   Tools/CmdLine/IccCommon/IccJsonUtil.cpp
    modified:   Tools/CmdLine/IccCommon/IccJsonUtil.h

These changes verify that the subprojects IccApplyNamedCmm and IccApplyProfiles will compile to binary form and Link properly.

Build Tools/CmdLine/IccApplyNamedCmm

cd Tools/CmdLine/IccApplyNamedCmm
cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Release . && make -j10  VERBOSE=1

Result

./iccApplyNamedCmm
iccApplyNamedCmm built with IccProfLib version 2.2.5

Build Tools/CmdLine/IccApplyProfiles

cd Tools/CmdLine/IccApplyProfiles
cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Release . 
make VERBOSE=1

Result

 ./iccApplyProfiles
iccApplyProfiles built with IccProfLib version 2.2.5