search

InternationalColorConsortium / DemoIccMAX

Demonstration Implementation for iccMAX color profiles
Other
121 stars 37 forks source link

Inconsistent validation results (missing validation checks) #51

Open jens-st opened 2 years ago

jens-st commented 2 years ago

Hi,
we included IccProfLib into one of our image validation tools. The tool calls CIccProfile::ReadValidate on embedded profiles.

We noticed that profiles validated with the IccDumpProfile CI Tool to be non-compliant, are still valid and compliant when tested with this IccProfLib call. One real-world example we encountered: First tag data that is on an offset rather than immediately after tag table (as expected by the ICC standard).

It seems IccDumpProfile implements more non-compliant checks and warnings. --> https://github.com/InternationalColorConsortium/DemoIccMAX/blob/master/Tools/CmdLine/IccDumpProfile/iccDumpProfile.cpp#L241-L304

Would it be possible to include those into IccProfLib as well to get consistent validation results and reports across all tools and libs in this project?

maxderhak commented 1 month ago

The iccDumpProfile CL tool uses ValidateProfile(). A memory based ValidateProfile() has been added to the PCS_Refactor branch and will be part of the 2.2.5 release when merged. Alternatively you can additionally call the CIccProfile::Validate() member to get the extra validation step.