InternationalColorConsortium / DemoIccMAX

Demonstration Implementation for iccMAX color profiles
Other
121 stars 37 forks source link

Fix macro casts in icProfileHeader.h #81

Closed kateniolet closed 4 months ago

kateniolet commented 4 months ago

Fix typos in various macros in icProfileHeader.h for enum bounds checking

kateniolet commented 4 months ago
  1. Good catch! Fixed to 'Function' and squashed into the commit.

the change of icMaxCurveElemSignature to icMaxToneFunctionSignature

was because icMaxCurveElemSignature appeared to have been copy-pasted by the original author into the file twice and the second time it was following the icToneFunctionSignature enum - as these are simply macros for referencing the highest value of their respective enums I renamed this second one to fit its conext.

  1. I'm not sure I understand the question - compiling is the same as usual, nothing changes there.
xsscx commented 4 months ago

For Documentation, I used the following yaml to test this PR using PR 66 which is the currrent Last Known Good Commit for Compile using:

name: C/C++ CI

on:
  push:
    branches: [ "master" ]
  pull_request:
    branches: [ "master" ]
  workflow_dispatch:

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v4
      with:
        ref: f891074a0f1c9d61a3dfa53749265f8c14ed4ee6

    - name: make
      run: |
        cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" -Wno-dev Build/Cmake
        make -j10

Result: PASS