xsscx
commented
3 months ago Hello @TahomaSoft
Thank you for confirming the compile issues with Host gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0. Below is a workaround and other Build Examples that are verified to compile across Ubuntu, macOS and Windows with Build Instructions noted in 77.
If I can provide any additional information, or help with compiling, etc.. please update this Issue.
Minimized Build Instructions
cd /tmp
git clone https://github.com/InternationalColorConsortium/DemoIccMAX.git
cd DemoIccMAX
git revert b90ac3933da99179df26351c39d8d9d706ac1cc6
cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" -Wno-dev Build/Cmake/
make -j$(nproc) 2>&1 | grep 'error:'For anyone wanting to Cherry Pick their way to the most recent build:
Cherry Picking Example
cd /tmp
git clone https://github.com/InternationalColorConsortium/DemoIccMAX.git
cd DemoIccMAX
git checkout f891074a0f1c9d61a3dfa53749265f8c14ed4ee6
git fetch origin
git cherry-pick 35787aa9ad33dc27448f1af68a0a5bfdde4fffba
git cherry-pick 1ed936f2d398c12c04b570f7cd3ad251c39bb483
git cherry-pick e71eacfa550ac9a092903ecc24feba9ae32ebaae
git cherry-pick 4f354f4d034a88230e6cabbc1f84ff0d9a4556ae
git cherry-pick c0ab97ddd1a0f792c8afb7a061135bc7c87f5854
cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" -Wno-dev Build/Cmake
make -j$(nproc) 2>&1 | grep 'error:'Result: Pass
Keep adding git cherry-pick for the Commits you want.
Cherry Picking Runner
name: C/C++ CI with Packaging
on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]
workflow_dispatch:
jobs:
build-and-package:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository at the base commit
uses: actions/checkout@v4
with:
ref: f891074a0f1c9d61a3dfa53749265f8c14ed4ee6
- name: Set up Git user
run: |
git config --global user.name "GitHub Actions"
git config --global user.email "actions@github.com"
- name: Fetch the latest changes
run: git fetch origin
- name: Cherry-pick commit 9c66ef2
run: |
git cherry-pick 9c66ef27a8f834c538430d17abaf14af32ee34e2 || (
echo "Conflict occurred during cherry-pick of commit 9c66ef2" && git cherry-pick --abort
)
- name: Cherry-pick commit 35787aa
run: |
git cherry-pick 35787aa9ad33dc27448f1af68a0a5bfdde4fffba || (
echo "Conflict occurred during cherry-pick of commit 35787aa" && git cherry-pick --abort
)
- name: Cherry-pick commit ede72ec
run: |
git cherry-pick ede72eca10cd8a19af90adc716e264c53c2f474d || (
echo "Conflict occurred during cherry-pick of commit ede72ec" && git cherry-pick --abort
)
- name: Cherry-pick commit 1ed936f
run: |
git cherry-pick 1ed936f2d398c12c04b570f7cd3ad251c39bb483 || (
echo "Conflict occurred during cherry-pick of commit 1ed936f" && git cherry-pick --abort
)
- name: Cherry-pick commit 163b38b
run: |
git cherry-pick 163b38b20779149967e5cf78f2300fbef790dc2b || (
echo "Conflict occurred during cherry-pick of commit 163b38b" && git cherry-pick --abort
)
- name: Cherry-pick commit e71eacf
run: |
git cherry-pick e71eacfa550ac9a092903ecc24feba9ae32ebaae || (
echo "Conflict occurred during cherry-pick of commit e71eacf" && git cherry-pick --abort
)
- name: Cherry-pick commit 4f354f4
run: |
git cherry-pick 4f354f4d034a88230e6cabbc1f84ff0d9a4556ae || (
echo "Conflict occurred during cherry-pick of commit 4f354f4" && git cherry-pick --abort
)
- name: Cherry-pick commit 1ed936f
run: |
git cherry-pick 1ed936f2d398c12c04b570f7cd3ad251c39bb483 || (
echo "Conflict occurred during cherry-pick of commit 1ed936f" && git cherry-pick --abort
)
- name: Cherry-pick commit 163b38b
run: |
git cherry-pick 163b38b20779149967e5cf78f2300fbef790dc2b || (
echo "Conflict occurred during cherry-pick of commit 163b38b" && git cherry-pick --abort
)
- name: Cherry-pick commit e71eacf
run: |
git cherry-pick e71eacfa550ac9a092903ecc24feba9ae32ebaae || (
echo "Conflict occurred during cherry-pick of commit e71eacf" && git cherry-pick --abort
)
- name: Cherry-pick commit c0ab97d
run: |
git cherry-pick c0ab97ddd1a0f792c8afb7a061135bc7c87f5854 || (
echo "Conflict occurred during cherry-pick of commit c0ab97d" && git cherry-pick --abort
)
- name: Cherry-pick commit c0ab97d
run: |
git cherry-pick c0ab97ddd1a0f792c8afb7a061135bc7c87f5854 || (
echo "Conflict occurred during cherry-pick of commit c0ab97d" && git cherry-pick --abort
)
- name: Cherry-pick commit 55f4f77
run: |
git cherry-pick -m 1 55f4f773498a294d35fe5d26a6fd5909dda8d57f || (
echo "Conflict occurred during cherry-pick of commit 55f4f77" && git cherry-pick --abort
)
- name: Cherry-pick commit dc78afc
run: |
git cherry-pick -m 1 dc78afcfe9e8cf0dd027e8dd30e21bebf101ffaa || (
echo "Conflict occurred during cherry-pick of commit dc78afc" && git cherry-pick --abort
)
- name: Run CMake and Build
run: |
cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" -Wno-dev Build/Cmake
make -j10
- name: Install the Build
run: make install
- name: Set executable permissions for binaries
run: |
find $HOME/.local/bin -type f -exec chmod +x {} \;
- name: Package build outputs
run: |
mkdir -p build_artifacts/bin
mkdir -p build_artifacts/lib
cp -r $HOME/.local/bin/* build_artifacts/bin/
cp -r $HOME/.local/lib/* build_artifacts/lib/
cp -r $HOME/.local/include build_artifacts/include
- name: Upload build artifacts
uses: actions/upload-artifact@v4
with:
name: build-artifacts
path: build_artifacts/Bisect
git bisect bad b90ac3933da99179df26351c39d8d9d706ac1cc6For those looking to bypass the Compile Issues, I posted Ubuntu x86_64, macos x86_64 and arm64 packages at URL https://github.com/xsscx/PatchIccMAX/tags
TahomaSoft
gcc --version gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0
In file included from /home/eeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccTag.h:90, from /home/eeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccCmm.h:77, from /home/eeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccApplyBPC.h:74, from /home/eeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccApplyBPC.cpp:71: /home/erikbeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccTagMPE.h:171:25: warning: ‘virtual CIccApplyMpe CIccMultiProcessElement::GetNewApply(CIccApplyTagMpe)’ was hidden [-Woverloaded-virtual=] 171 | virtual CIccApplyMpe GetNewApply(CIccApplyTagMpe pApplyTag); | ^
~~/home/eeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccTagMPE.h:255:25: note: by ‘virtual CIccApplyMpe CIccMpeUnknown::GetNewApply()’ 255 | virtual CIccApplyMpe GetNewApply() { return NULL; } | ^~~/home/eeck/Build/DemoICCMax/DemoIccMAX/IccProfLib/IccCmm.h:1246:37: error: expected ‘)’ before ‘’ token 1246 | CIccApplyNDLutXform(CIccXformNDLut pXform, CIccApplyCLUT* pApply); | ~ ^ | )