FIX: alloc-dealloc-mismatches | Fix Typo: icSigUnkownPlatform corrected to icSigUnknownPlatform

[xsscx]

PR94

Refactored By: @xsscx Date: 10 September 2024 Original Issue in https://github.com/InternationalColorConsortium/DemoIccMAX/issues/84

Method of Identification: A regex pattern matching approach was used to search for the known typo icSigUnkownPlatform across all .h and .cpp files in the project. The incorrect occurrences were found and replaced with the correct spelling icSigUnknownPlatform.

Description: This PR resolves a typo present in several files where icSigUnkownPlatform is mistakenly used instead of icSigUnknownPlatform. This typo was identified using regex pattern matching and has been corrected across all relevant files.

Changes Made: Search: icSigUnkownPlatform Replace: icSigUnknownPlatform The following files have been updated:

IccProfLib/icProfileHeader.h: Line: icSigUnkownPlatform = 0x00000000 → icSigUnknownPlatform = 0x00000000 IccXML/IccLibXML/IccProfileXml.cpp: Condition check: if (m_Header.platform != icSigUnkownPlatform) → if (m_Header.platform != icSigUnknownPlatform) IccProfLib/IccUtil.cpp: Case: case icSigUnkownPlatform: → case icSigUnknownPlatform: IccProfLib/IccProfile.cpp: Case: case icSigUnkownPlatform: → case icSigUnknownPlatform:

Memory Management Issues

Description: The code in CIccTagSpectralViewingConditions and CIccProfile exhibits improper memory management practices. There is a mismatch in allocation and deallocation methods for dynamically allocated memory. This leads to the detection of alloc-dealloc-mismatch errors by AddressSanitizer.

PoC

~/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/Testing/Calc$ ../iccFromXml CameraModel.xml CameraModel.icc
...
ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete []) on 0x614000000a40
    #0 0x7f0eb134ae57 in operator delete[](void*) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:163
    #1 0x7f0eaf6ef9e5 in CIccTagSpectralViewingConditions::~CIccTagSpectralViewingConditions() /home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/IccProfLib/IccTagBasic.cpp:10908
    #2 0x7f0eb0e3b006 in CIccTagXmlSpectralViewingConditions::~CIccTagXmlSpectralViewingConditions() (/home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/Build/IccXML/libIccXML2.so.2+0x4e1006)
    #3 0x7f0eb0e3b037 in CIccTagXmlSpectralViewingConditions::~CIccTagXmlSpectralViewingConditions() (/home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/Build/IccXML/libIccXML2.so.2+0x4e1037)
    #4 0x7f0eaf58115e in CIccProfile::Cleanup() /home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/IccProfLib/IccProfile.cpp:263
    #5 0x7f0eaf58019e in CIccProfile::~CIccProfile() /home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/IccProfLib/IccProfile.cpp:239
    #6 0x56030e3bad89 in CIccProfileXml::~CIccProfileXml() /home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/Build/Cmake/../../IccXML/IccLibXML/IccProfileXml.h:82
    #7 0x56030e3b9f99 in main /home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/IccXML/CmdLine/IccFromXml/IccFromXml.cpp:113
    #8 0x7f0ead6ead8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #9 0x7f0ead6eae3f in __libc_start_main_impl ../csu/libc-start.c:392
    #10 0x56030e3b88c4 in _start (/home/xss/tmp/git/PatchMAX-f891074a0f1c9d61a3dfa53749265f8c14ed4ee6/Build/Tools/IccFromXml/iccFromXml+0x88c4)

Issue 1

File: IccTagBasic.cpp Line: 10908 Incorrect use of delete[] for memory allocated using malloc. CIccProfile Cleanup Function:

malloc()

The code from IccTagXml.cpp#L2105 shows the allocation of m_observer using malloc:

if (pChild->children && pChild->children->content) {
    CIccFloatArray vals;
    vals.ParseTextArray((icChar*)pChild->children->content);
    if (vals.GetSize() != m_observerRange.steps * 3)
        return false;
    m_observer = (icFloatNumber*)malloc(m_observerRange.steps * 3 * sizeof(icFloatNumber));
    if (!m_observer)
        return false;
    icFloatNumber *pBuf = vals.GetBuf();
    memcpy(m_observer, pBuf, m_observerRange.steps * 3 * sizeof(icFloatNumber));
}

Corrected Destructor

Given that m_observer is allocated using malloc, it should be deallocated using free in the destructor.

Here is the corrected destructor code:

Refactored Code

/**
 ****************************************************************************
 * Name: CIccTagSpectralViewingConditions::~CIccTagSpectralViewingConditions
 * 
 * Purpose: Destructor
 * 
 *****************************************************************************
 */
CIccTagSpectralViewingConditions::~CIccTagSpectralViewingConditions()
{
  if (m_observer)
    free(m_observer);  // Correct deallocation for malloc

  if (m_illuminant)
    free(m_illuminant);  // Correct deallocation for malloc
}

History

The initial Commit is from 2015. Address Sanitizer reported a alloc-dealloc-mismatch (malloc vs operator delete []) when run on Ubuntu and macOS in 2024.

malloc () Guidelines

Allocation Functions:

• malloc – for dynamic memory allocation.
• calloc – for zero-initialized dynamic memory allocation.
• new – for object creation that also allocates memory.

Deallocation Functions:

• free – for deallocating memory allocated with malloc or calloc.
• delete – for deallocating memory allocated with new.
• delete[] – for deallocating memory allocated with new[].

Other Functions:

• realloc – used to resize dynamically allocated memory.
• memcpy or memmove – often appear near dynamic memory handling for copying contents from one block of memory to another.
• strdup – dynamically allocates memory to copy a string, typically requires free() for deallocation.

Issue 2

File: IccProfile.cpp Line: 263 Improper handling of dynamically allocated memory using manual delete and free operations.

Refactored Code

/**
 ****************************************************************************
 * Name: CIccProfile::Cleanup
 * 
 * Purpose: Detach from a pending IO object
 *****************************************************************************
 */
void CIccProfile::Cleanup()
{
  // Delete the attached IO object if it exists
  if (m_pAttachIO) {
    delete m_pAttachIO;
    m_pAttachIO = nullptr;
  }

  // Iterate through the tag values and delete them if they are not null
  for (auto &tagVal : *m_TagVals) {
    if (tagVal.ptr != nullptr) {
      delete tagVal.ptr;
      tagVal.ptr = nullptr;
    }
  }

  // Clear the tag lists
  m_Tags->clear();
  m_TagVals->clear();

  // Reset the header to zero
  std::memset(&m_Header, 0, sizeof(m_Header));
}

Explanation of Changes

Nullptr Assignment: Replaced NULL with nullptr for better type safety and clarity. After deleting pointers, set them to nullptr to avoid dangling pointers.

Range-based Loop: Replaced the manual iterator loop with a range-based loop for better readability and to reduce the potential for errors.

Clear Lists: Clear the tag lists using the clear method of the standard library containers.

Memset: Used std::memset instead of memset to adhere to C++ standards.

Memory Allocation Consistency: Ensure that the memory for m_pAttachIO and tagVal.ptr is consistently allocated with new if they are deleted with delete.

Issue 3 - Other Patches

 git diff IccProfLib/IccCmm.cpp.unpatched IccProfLib/IccCmm.cpp
diff --git a/IccProfLib/IccCmm.cpp.unpatched b/IccProfLib/IccCmm.cpp
index 32582e2..abe7e2f 100644
--- a/IccProfLib/IccCmm.cpp.unpatched
+++ b/IccProfLib/IccCmm.cpp
@@ -1937,21 +1937,21 @@ CIccApplyPcsXform::CIccApplyPcsXform(CIccXform *pXform) : CIccApplyXform(pXform)
 */
 CIccApplyPcsXform::~CIccApplyPcsXform()
 {
-
-  if (m_list) {
-    CIccApplyPcsStepList::iterator i;
-    for (i=m_list->begin(); i!=m_list->end(); i++) {
-      if (i->ptr)
-        delete i->ptr;
+    if (m_list) {
+        for (auto& step : *m_list) {
+            if (step.ptr) {
+                delete step.ptr; // Properly deallocate the object
+                step.ptr = nullptr; // Nullify pointer after deletion for safety
+            }
+        }
+        delete m_list;
+        m_list = nullptr; // Nullify pointer after deletion for safety
     }

-    delete m_list;
-  }
-
-  if (m_temp1)
-    delete m_temp1;
-  if (m_temp2)
-    delete m_temp2;
+    delete[] m_temp1; // Use delete[] to match array allocation
+    delete[] m_temp2; // Use delete[] to match array allocation
+    m_temp1 = nullptr; // Nullify pointer after deletion for safety
+    m_temp2 = nullptr; // Nullify pointer after deletion for safety
 }

 /**
@@ -3891,30 +3891,30 @@ CIccPcsStep *CIccPcsStepXYZToLab2::concat(CIccPcsStep *pNext) const
 /**
 **************************************************************************
 * Name: CIccPcsStepOffset::CIccPcsStepOffset
-*
-* Purpose:
-*  Constructor
+*
+* Purpose:
+*  Constructor - Initializes the offset with the given number of channels.
 **************************************************************************
 */
 CIccPcsStepOffset::CIccPcsStepOffset(icUInt16Number nChannels)
 {
-  m_nChannels = nChannels;
-  m_vals = new icFloatNumber[nChannels];
+    m_nChannels = nChannels;
+    m_vals = new icFloatNumber[nChannels]; // Allocate an array using new[]
 }

 /**
 **************************************************************************
-* Name: CIccPcsStepOffset::CIccPcsStepOffset
-*
-* Purpose:
-*  Destructor
+* Name: CIccPcsStepOffset::~CIccPcsStepOffset
+*
+* Purpose:
+*  Destructor - Cleans up allocated resources.
 **************************************************************************
 */
 CIccPcsStepOffset::~CIccPcsStepOffset()
 {
-  if (m_vals)
-    delete m_vals;
+    delete[] m_vals; // Use delete[] to properly deallocate the array
+    m_vals = nullptr; // Nullify the pointer for safety
 }

@@ -4030,30 +4030,30 @@ bool CIccPcsStepOffset::isIdentity() const
 /**
 **************************************************************************
 * Name: CIccPcsStepScale::CIccPcsStepScale
-*
-* Purpose:
-*  Constructor
+*
+* Purpose:
+*  Constructor - Initializes the scale with the given number of channels.
 **************************************************************************
 */
 CIccPcsStepScale::CIccPcsStepScale(icUInt16Number nChannels)
 {
-  m_nChannels = nChannels;
-  m_vals = new icFloatNumber[nChannels];
+    m_nChannels = nChannels;
+    m_vals = new icFloatNumber[nChannels]; // Allocate an array using new[]
 }

 /**
 **************************************************************************
 * Name: CIccPcsStepScale::~CIccPcsStepScale
-*
-* Purpose:
-*  Destructor
+*
+* Purpose:
+*  Destructor - Cleans up allocated resources.
 **************************************************************************
 */
 CIccPcsStepScale::~CIccPcsStepScale()
 {
-  if (m_vals)
-    delete m_vals;
+    delete[] m_vals; // Use delete[] to properly deallocate the array
+    m_vals = nullptr; // Nullify the pointer for safety
 }

 /**

Issue 4

Update IccTagComposite.cpp FIX: alloc-dealloc-mismatch in m_TagVals and m_pArray

/**
***************************************************************************
* Name: CIccTagArray::Cleanup
*
* Purpose: Detach from a pending IO object
*
*
* 10 Sep 2024 - David Hoyt - Modify Memory Management
*               FIX: alloc-dealloc-mismatch in m_TagVals and m_pArray
*
***************************************************************************
*/
void CIccTagArray::Cleanup()
{
  // Sanity check: Ensure valid array size and non-null pointer
  if (m_nSize == 0 || !m_TagVals) {
    return; // Nothing to clean up
  }

  icUInt32Number i, j;
  CIccTag* pTag = nullptr;

  // Iterate over all tags in the array
  for (i = 0; i < m_nSize; i++) {
    pTag = m_TagVals[i].ptr;

    // Check if the current tag is valid
    if (pTag) {
      // Prevent double deletion by nullifying duplicate references
      for (j = i + 1; j < m_nSize; j++) {
        if (m_TagVals[j].ptr == pTag) {
          m_TagVals[j].ptr = nullptr; // Avoid deleting the same object twice
        }
      }

      // Securely delete the tag object and nullify the pointer
      delete pTag; 
      m_TagVals[i].ptr = nullptr;
    }
  }

  // Free the array memory and set the pointer to null to avoid dangling pointers
  if (m_TagVals) {
    free(m_TagVals);  // Release m_TagVals with free to resolve alloc-dealloc-mismatch
    m_TagVals = nullptr; // Prevent dangling pointer
  }

  // Deallocate m_pArray if it was allocated
  if (m_pArray) {
    delete[] m_pArray;  // Release m_pArray with delete[] to resolve alloc-dealloc-mismatch
    m_pArray = nullptr; // Prevent dangling pointer
  }

  // Reset the signature to indicate an undefined state
  m_sigArrayType = icSigUndefinedArray;
}

[maxderhak]

These are mostly good changes which I have mostly incorporated into the PCS_Refactor branch. There are some aspects that I question.

1. there is no real need to set a pointer to nullptr in a class destructor
2. CIccTagArray::Cleanup really needs to set the object to a known state and not just return. Additionally CIccTagArray.m_pArrray is a pointer to an IIccArray object not an new [] object pointer so delete [] is not needed

Note: Several IccXmlMpe fixes were also incorporated into the PCS_Refactor branch. It still needs testing and a bit of documentation, but I'm thinking its going in the right direction.

[xsscx]

@maxderhak A quick check on the PCS_Refactor Branch, applying the revert, build, and then Asan Reports that allocator issue when creating profiles.

Allocator PoC

/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/xsscx/PatchIccMAX/refs/heads/development/contrib/UnitTest/pcs_revert_build_asan_report.sh)"

Build Log

      |                                          ^
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp: In member function ‘virtual bool CIccTagXmlCurve::ParseXml(xmlNode*, icConvertType, std::string&)’:
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2601:15: warning: ‘void free(void*)’ called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
 2601 |           free(buf);
      |           ~~~~^~~~~
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2594:42: note: returned from ‘void* operator new [](std::size_t)’
 2594 |         char *buf = (char *) new char[num];
      |                                          ^
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2611:15: warning: ‘void free(void*)’ called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
 2611 |           free(buf);
      |           ~~~~^~~~~
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2594:42: note: returned from ‘void* operator new [](std::size_t)’
 2594 |         char *buf = (char *) new char[num];
      |                                          ^
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2626:17: warning: ‘void free(void*)’ called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
 2626 |             free(buf);
      |             ~~~~^~~~~
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2594:42: note: returned from ‘void* operator new [](std::size_t)’
 2594 |         char *buf = (char *) new char[num];
      |                                          ^
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2663:17: warning: ‘void free(void*)’ called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
 2663 |             free(buf);
      |             ~~~~^~~~~
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2594:42: note: returned from ‘void* operator new [](std::size_t)’
 2594 |         char *buf = (char *) new char[num];
      |                                          ^
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2695:17: warning: ‘void free(void*)’ called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
 2695 |             free(buf);
      |             ~~~~^~~~~
/tmp/tmm/DemoIccMAX/IccXML/IccLibXML/IccTagXml.cpp:2594:42: note: returned from ‘void* operator new [](std::size_t)’
 2594 |         char *buf = (char *) new char[num];
      |                                          ^

Reproduction

#!/bin/sh
##
## Unit Test for PCS_Refactor
## Asan Checks for CreateAllProfiles.sh
##
## David Hoyt for DemoIccMAX Project
## Date: 27-Sept-24
##

echo "Step 1: Configuring Git user for this session"
git config --global user.email "github-actions@github.com" || { echo "Error: Git config failed. Exiting."; exit 1; }
git config --global user.name "GitHub Actions" || { echo "Error: Git config failed. Exiting."; exit 1; }
echo "Git user configuration done."

echo "Step 2: Cloning DemoIccMAX repository"
git clone https://github.com/InternationalColorConsortium/DemoIccMAX.git || { echo "Error: Git clone failed. Exiting."; exit 1; }
cd DemoIccMAX/ || { echo "Error: Failed to change directory to DemoIccMAX. Exiting."; exit 1; }
echo "Repository cloned and switched to DemoIccMAX directory."

echo "Step 3: Checking out PCS_Refactor branch"
git checkout PCS_Refactor || { echo "Error: Git checkout PCS_Refactor failed. Exiting."; exit 1; }
echo "PCS_Refactor branch checked out."

echo "Step 4: Attempting to revert commit b90ac3933da99179df26351c39d8d9d706ac1cc6 non-interactively"
# Perform the revert non-interactively, skip conflicts, and use the current branch's version.
git revert --no-edit b90ac3933da99179df26351c39d8d9d706ac1cc6 || { echo "Revert conflict detected. Attempting to resolve conflicts automatically."; }

# Check if there are conflicts
if [ $(git ls-files -u | wc -l) -gt 0 ]; then
    echo "Conflicts found. Resolving conflicts automatically by using the current branch version."
    git ls-files -u | awk '{print $4}' | xargs git add

    echo "Continuing the revert after resolving conflicts"
    git revert --continue || { echo "Error: Git revert --continue failed. Exiting."; exit 1; }
else
    echo "No conflicts detected. Revert completed successfully."
fi

echo "Step 5: Changing to Build directory"
cd Build/ || { echo "Error: Directory change to Build/ failed. Exiting."; exit 1; }
echo "Changed to Build directory."

echo "Step 6: Configuring the build with CMake"
cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local \
      -DCMAKE_BUILD_TYPE=Debug \
      -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" \
      -Wno-dev Cmake/ || { echo "Error: CMake configuration failed. Exiting."; exit 1; }
echo "CMake configuration completed."

echo "Step 7: Building the code with make"
make -j32 || { echo "Error: Build failed. Exiting."; exit 1; }
echo "Build completed successfully."

# Optionally, uncomment and adjust the test step if required
echo "Step 8: Running the tests"
cd ../Testing || { echo "Error: Directory change to Testing failed. Exiting."; exit 1; }
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/xsscx/PatchIccMAX/refs/heads/development/contrib/UnitTest/pcs_refactor_create_profiles.sh)" > CreateAllProfiles.log 2>&1 || { echo "Error: Test script execution failed. Exiting."; ex
it 1; }
echo "Tests completed. Logs saved in CreateAllProfiles.log."

echo "All steps completed successfully."

Github Action

name: PCS_Refactor Revert 06ac1cc6

on:
  workflow_dispatch:    # Allows manual triggering from the Actions tab in GitHub
  push:                 # Automatically triggers on push events to the PCS_Refactor branch (optional)
    branches:
      - PCS_Refactor

jobs:
  revert_commit_and_build:
    runs-on: ubuntu-latest

    steps:
    - name: Set up Git anonymous identity
      run: |
        git config --global user.email "github-actions@github.com"
        git config --global user.name "GitHub Actions"

    - name: Remove existing DemoIccMAX directory (if it exists)
      run: |
        if [ -d "DemoIccMAX" ]; then
          rm -rf DemoIccMAX
        fi

    - name: Checkout Code
      run: |
        git clone https://github.com/InternationalColorConsortium/DemoIccMAX.git
        cd DemoIccMAX
        git checkout PCS_Refactor

    # Install Dependencies
    - name: Install Dependencies
      run: |
        sudo apt-get update

        # Check and install if packages are not installed
        for pkg in libwxgtk-media3.0-gtk3-dev libwxgtk-webview3.0-gtk3-dev \
                   libwxgtk3.0-gtk3-dev libxml2 libtiff5 libxml2-dev libtiff5-dev \
                   clang-tools; do
          if ! dpkg-query -W -f='${Status}' $pkg | grep "install ok installed"; then
            echo "Installing $pkg"
            sudo apt-get install -y $pkg
          else
            echo "$pkg is already installed"
          fi
        done

    - name: Attempt Revert
      run: |
        cd DemoIccMAX
        git revert --no-edit b90ac3933da99179df26351c39d8d9d706ac1cc6 || true

    - name: Handle Conflict Locally
      run: |
        cd DemoIccMAX
        if [ -f Tools/CmdLine/IccCommon/IccCmmConfig.cpp ]; then
          # Resolve conflict by removing the file (this will not persist in the repository)
          git rm Tools/CmdLine/IccCommon/IccCmmConfig.cpp
          git add .
          git revert --continue || true
        else
          echo "No conflict resolution needed"
        fi

    # Configure the build with CMake (keeping Cmake/ directory)
    - name: Configure the build with CMake
      run: |
        cd DemoIccMAX/Build/
        cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local \
              -DCMAKE_BUILD_TYPE=Debug \
              -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" \
              -Wno-dev Cmake/

    # Build the project with make and log output
    - name: Build project with make and log output
      run: |
        cd DemoIccMAX/Build/
        make -j8 > ../../build.log 2>&1 || true  # Ensuring log goes to correct path relative to root

    # Check build success (by searching for errors in the build log)
    - name: Check build success
      run: |
        if grep -i "error" ../../build.log; then
          echo "❌ Build Failed"
          exit 1
        else
          echo "✅ Build Succeeded"
        fi

    # Create artifact directory for binaries
    - name: Create artifact directory
      run: mkdir -p DemoIccMAX/Build/artifact

    # Move only .lib, .a, .so, .dll, and binaries (including a.out) to artifact directory
    - name: Move libraries and binaries to artifact directory
      run: |
        find DemoIccMAX/Build/ -type f \( -name '*.lib' -o -name '*.a' -o -name '*.so' -o -name '*.dll' -o -name 'a.out' -o -executable \) -exec mv {} DemoIccMAX/Build/artifact/ \;

    # Clean the target directory before moving artifacts
    - name: Clean target directory before moving artifacts
      run: |
        if [ -d "DemoIccMAX-build-ubuntu-latest" ]; then
          rm -rf DemoIccMAX-build-ubuntu-latest
        fi

    # Label Artifacts for ubuntu-latest
    - name: Label Artifacts for ubuntu-latest
      run: mv DemoIccMAX/Build/artifact DemoIccMAX-build-ubuntu-latest

    # Upload build artifacts for ubuntu-latest
    - name: Upload build artifacts
      uses: actions/upload-artifact@v4
      with:
        name: DemoIccMAX-build-ubuntu-latest
        path: DemoIccMAX-build-ubuntu-latest/

    # Upload build log as an artifact
    - name: Upload build log
      uses: actions/upload-artifact@v4
      with:
        name: build-log
        path: build.log

    - name: Debug Git Status (Optional for checking result)
      run: |
        cd DemoIccMAX
        git status

    - name: Clean Up
      run: |
        cd DemoIccMAX
        git reset --hard HEAD
        git clean -fd