search

InternationalScratchWiki / ScratchWikiSkin2

Skin for the Scratch Wiki.
https://en.scratch-wiki.info
MIT License
17 stars 15 forks source link

VisualEditor windows are cut off #123

Closed ghost closed 1 month ago

ghost commented 1 year ago

image (screenshot taken in an unsaved edit to my sandbox on the English Wiki) VisualEditor windows are cut off, for example, when pressing the link button when editing. This would make it virtually impossible to add links or some other features when editing with VisualEditor.

ghost commented 1 year ago

image This seems to be the cause; the height of these popups is not set by our skin whilst Vector 2022 (added in the 1.39 upgrade) does (although I do not know where it is being set for this element, as it uses inline style)

Kenny2github commented 8 months ago

Noticed this during the course of another PR. This completely disables VE features using such popups. Elevating priority.

jacob-g commented 1 month ago

This appears to have been resolved in a more recent release of VisualEditor. Please reopen if this issue recurs.

Kenny2github commented 1 month ago

This was actually resolved tangentially in #131 but I forgot to note that here.