search

InternationalScratchWiki / ScratchWikiSkin2

Skin for the Scratch Wiki.
https://en.scratch-wiki.info
MIT License
17 stars 15 forks source link

Add support for checking Echo notifications #129

Closed mrsrec closed 8 months ago

mrsrec commented 8 months ago

Echo is broken on ScratchWikiSkin2 "out-of-the-box" because it adds weird, broken elements into a dropdown.

Now we're filtering those and adding our own custom notifications button to the navbar. This will show if you have unread notifications, and if so, link you to Special:Notifications

In the future it would be nice to implement the pop-up instead of linking the user, and generating the link MW instead of hard-coding it, but I believe this is low-priority since it will fix itself.

mrsrec commented 8 months ago

One unrelated thing that I forgot I added here: this fixes duplicating the ID "feet".

mrsrec commented 8 months ago

@jacob-g Should be changed now.

Kenny2github commented 8 months ago

Removed myself from review as I pushed directly. I realize that the connection of some of these changes to the original purpose of the PR is tenuous at best, so I can rebase them out and into another PR if desired, but I feel like they have been overdue and should be included. The main noteworthy contribution of mine is that it now shows the number of notifications like Scratch does. @jacob-g I think this is now ready for your review.