Dark theme fixes 2023 - Githubissues

InternationalScratchWiki / ScratchWikiSkin2

Skin for the Scratch Wiki.

https://en.scratch-wiki.info

MIT License

17 stars 15 forks source link

Dark theme fixes 2023 #131

Closed Kenny2github closed 8 months ago

Kenny2github commented 8 months ago

Fixes issues reported on the Community Portal between 2022-03-15 and today, plus some that I noticed along the way.

jacob-g commented 8 months ago

Update since I have CodeMirror working:

CodeMirror gutter: PASS
CodeMirror selection: PASS

jacob-g commented 8 months ago

Update when I got pending to work (using Special:Contributions and searching a username):

pending interference: PASS

jacob-g commented 8 months ago

Another update now that I have looked more closely at the WikiEditor help table:

WikiEditor help table: PASS (special characters still is dark on dark, but can be fixed at a later time)

jacob-g commented 8 months ago

Another update now that I have been informed that the caption invisibility issue is in template documentation:

captions being invisible: PASS

Kenny2github commented 8 months ago

fix preview warning being too bright: PARTIAL PASS (contrast is low with the dark-ish text on a dark background; this can be fixed at a later time if needed)

contrast ratio passes WCAG AAA standard image of actual preview warning

Not sure how much more contrast you need?

Kenny2github commented 8 months ago

Addressed review comments and also fixed a swath of issues I noticed while doing so

jacob-g commented 8 months ago

For previous issues identified: fix preview warning being too bright: PASS VisualEditor fixes: PASS page history: PASS

This addresses all issues from my earlier review. Now I will proceed reviewing the new fixes.

jacob-g commented 8 months ago

Results: message box styling: CANNOT TEST (not sure what the original issue is) special characters: PASS VisualEditor/OOUI issues: PASS OOUI borders: CANNOT TEST (not sure what the original issue is) preferences: CANNOT TEST (not sure what the original issue is) Recent Changes: CANNOT TEST (not sure what the original issue is) VisualEditor pop-ups: PASS Echo issues: PASS reference highlighting: PASS

Kenny2github commented 8 months ago

Original issues:

message box styling: the "change your password, it's too simple" warning on login was badly styled. It seems that newer versions of MW use a more MW-specific class, rendering the original fix ineffective, so I added the one used in that warning and extrapolated to the other classes.
OOUI borders: generally there was inconsistency between some buttons/input elements/etc. having dark or light borders, especially in the VisualEditor gallery modal and Special:Log/Special:Contributions. I made them all light (as far as I can tell).
preferences: the Echo notification settings table's even-numbered rows were light on light. The timezone input was also bad.
Recent Changes: one button had a doubly thick border, the legend flashbanged during loading, and the buttons in the bottom right of the filter panel were misaligned with the rest of the bottom buttons.

jacob-g commented 8 months ago

message box styling: PASS OOUI borders: PARTIAL PASS - you introduced a regression with the dropdown arrow (this problem isn't present on the pre-fix version) preferences: PASS Recent Changes: PASS

Kenny2github commented 8 months ago

Tag filter drop-down arrow is not a blocker (it will take significantly more effort and is not a dark-on-dark/light-on-light issue) so it can go in the next batch of fixes