InternationalScratchWiki / ScratchWikiSkin2

Skin for the Scratch Wiki.
https://en.scratch-wiki.info
MIT License
17 stars 15 forks source link

Mobile design! #38

Closed Kenny2github closed 6 years ago

Kenny2github commented 6 years ago

Mobile design is under way for the Scratch Wikis. You can see a public draft of the mobile design here: https://hkugawiki.ddns.net/test/Main_Page

Please comment with any issues or suggestions.

Checklist:

mtwoll commented 6 years ago

looks good!

LiFaytheGoblin commented 6 years ago

Can someone else review? I'll have time on Sunday but not before...

Kenny2github commented 6 years ago

@LiFaytheGoblin it's ok if you review on Sunday, since I was thinking you would review during Scratch Club.

LiFaytheGoblin commented 6 years ago

I'm in EST time zone till October so I can't join the Scratch Club till then. I'll review it on Sunday then. I'll let you know if something comes up.

mtwoll commented 6 years ago

I had a brief look at it and liked what I saw, so I‘m still at vacation in Denmark.

Kenny2github commented 6 years ago

@LiFaytheGoblin ping!

LiFaytheGoblin commented 6 years ago

Sorry, I was unexpectedly moving on Sunday so I didn't have time. Later this week!

LiFaytheGoblin commented 6 years ago

I checked out the website you linked to. It looks pretty good so far. The log-in menu is not quite in the view for me tho. Is there a way I can test this locally or would I need to set up a wiki?

Kenny2github commented 6 years ago

@LiFaytheGoblin The login menu isn't in the view? What width is your screen? and OS&browser?

EDIT: ah, it happened to me too, I wasn't hiding enough links. Is it fixed for you?

Kenny2github commented 6 years ago

Okay, I've added the tutorial for mobile users about swiping for the sidebar. Could someone make sure it works on their own device? :p

mtwoll commented 6 years ago

works for me at iOS! :-)

apple502j commented 6 years ago

https://github.com/InternationalScratchWiki/ScratchWikiSkin2/blob/mobile/ScratchWikiSkinTemplate.php#L345 Error "Cannot set property 'innerHTML' of undefined"

This seems to occur when we change responsive mode and normal mode

Is it all right since nobody except for developers will get it?

On Windows 10, Chrome 68

apple502j commented 6 years ago

On Windows 10 Chrome 68 Responsive Mode

"wipe left to hide it" S is hidden in iPhone 5 landscape

apple502j commented 6 years ago

There should be a way to skip the tutorial via URL.

Kenny2github commented 6 years ago

@apple502j fixed first two problems; but no, there doesn't need to be a way to skip the tutorial.

LiFaytheGoblin commented 6 years ago

Looks good now thanks!

apple502j commented 6 years ago

@Kenny2github And we also need a way to force desktop skin, via link or preferences

Kenny2github commented 6 years ago

@apple502j no, that doesn't work. You're thinking of MobileFrontend, which detects browser and OS details to present a different skin. This is responsive design, which is almost pure CSS and cannot be customized with a query parameter.

Kenny2github commented 6 years ago

@jacob-g any comments?

apple502j commented 6 years ago

One more: qqq is missing...

Kenny2github commented 6 years ago

@apple502j Done

Kenny2github commented 6 years ago

jvvg gave the OK on Discord. Time to merge!