Showing "not required" on search dropdown for non-logged-in users

[jacob-g]

Issue was reported by LOLScratch12233, screenshot below (provided by aforementioned user here).

[Kenny2github]

I find it highly unlikely that this is legitimate, considering the only part of the code that ever said "Not required" was just recently removed.

[Ascor8522]

Some (French-speaking) users also noticed it and asked me about it, tho it was not showing up on my screen (but was still there when viewing the source of the page).

[jacob-g]

I will try to reproduce this tomorrow using BrowserStack to emulate an iPad. I personally have not experienced it on Firefox on Windows or Android.

[jacob-g]

Reproduced in BrowserStack for iPad Safari:

[jacob-g]

Also reproduced in Chrome on Windows:

Reprioritizing as high priority

[jacob-g]

Here is the relevant section in the inspector:

[jacob-g]

This issue only affects non-logged in users. Also removing "mobile" tag since this occurs on desktop too

[jacob-g]

As @Ascor8522 reported, this is also included in the HTML source for non-logged-in users, so it's not added after the fact with JS. I don't see where it's added by the skin, so this probably comes from some other extension monkeying with our markup? This also does not happen on my local or staging (which does not have all the extensions we do on production), reinforcing that notion.

[jacob-g]

I can't find any extensions on EN that aren't also on staging that would be remotely linked to this.

[jacob-g]

Grepping shows a bunch of cache entries, so I'll try clearing the cache

[jacob-g]

Purging the cache entry for the main page seems to fix the issue there.

[jacob-g]

Cache purged for EN and FR, that seems to fix the problem. Note that we may see some transient performance issues.

[jacob-g]

I nuked the file cache, that seems to be fixing it.

[Ascor8522]

I don't see where it's added by the skin, so this probably comes from some other extension monkeying with our markup?

That's what I originally thought too, but it was part of the skin all along. Maybe some recent change in the CSS made it appear.

See the initial commit

https://github.com/InternationalScratchWiki/ScratchWikiSkin2/blob/f4d658fc521ad265e9fe171a0e2f5c2541b4c388/ScratchWikiSkinTemplate.php#L39-L43

And the commit that removed it

https://github.com/InternationalScratchWiki/ScratchWikiSkin2/blob/8e144e9a82587a39cf86cc5c878f6151da1151d8/ScratchWikiSkinTemplate.php#L83-L86

[jacob-g]

@Ascor8522 I think it was due to it being cached from before we removed that. Clearing the cache seems to have fixed it.