InternationalTradeAdministration / developer-best-practices

3 stars 1 forks source link

Commenting code - clarify scope for removing commented code #2

Closed jstorey-milcorp-ita closed 5 years ago

jstorey-milcorp-ita commented 5 years ago

I want to encourage people to commit early, commit often, push likewise, and create PRs early for review by team members, increasing the number of eyes on code and likely help identify issues earlier in the process. Therefore I prefer having softer guidelines for interim code.

christiancoleman commented 5 years ago

@jstorey-milcorp-ita I think that's a really great change. I'm going to be updating the README to a slightly different format here in a minute, but I don't see this idea being any way controversial. I'm going to approve without a vote.