search

InternationalTradeAdministration / developer-best-practices

3 stars 1 forks source link

Suggested best practices discussion #1 #3

Closed christiancoleman closed 5 years ago

christiancoleman commented 5 years ago

Please start a discussion or use emotes to vote. Whatever you want. This is a new process and we can work out the best way forward as we tinker.

scottpelak commented 5 years ago

Maybe we should have a README per topic. I wish there was a Pull Request for each proposed change.

Could automate combining all READMEs into a master README with Docker-script/Github-action

christiancoleman commented 5 years ago

That's not a bad idea. I was thinking about having everyone go to the file section and then select the line or individual best practice that want to discuss and then go from there. Then I was going to edit the PR to only include the ones we agreed on. So we'd be doing them in batches, but if certain things can be expedited like 'no soqls in a for loop' then I could see that being it's own PR because it could be approved pretty easily.

On Tue, Nov 20, 2018 at 12:12 PM Scott Pelak notifications@github.com wrote:

Maybe we should have a README per topic. I wish there was a Pull Request for each proposed change

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/InternationalTradeAdministration/developer-best-practices/pull/3#issuecomment-440353053, or mute the thread https://github.com/notifications/unsubscribe-auth/AFxV7KbS87-4JyXZQXflJfLgfPDNZAPyks5uxDf5gaJpZM4Yri-u .