InternetHealthReport / ihr-django

Internet Health Report API
https://ihr.iijlab.net/ihr/en-us/api
GNU General Public License v3.0
15 stars 21 forks source link

Error management in USM #34

Open leodarkseid opened 1 year ago

leodarkseid commented 1 year ago

the repo currently as a const.py module that contains errors. but the r'^user/register$', r'^user/login$',r'^user/sendregisteremail$', and r'^user/login$', all give the same response 200 in most scenarios, even when no data is passed and an error 400 is expected, that makes it a little harder to tell if requests are successful or not

romain-fontugne commented 1 year ago

Thanks! are you planning to fix this?

leodarkseid commented 1 year ago

Yes, I will

leodarkseid commented 1 year ago

@romain-fontugne not sure if this should be closed as it should be a continuous development, and it will be nice to have automated test to ensure future pull request don't break anything