[migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR #669 - Githubissues

InternetHealthReport / ihr-website

Vue.js code for IHR website

https://ihr.iijlab.net/ihr/en

GNU General Public License v3.0

65 stars 122 forks source link

[migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR #669 #717

Closed mohamedawnallah closed 11 months ago

mohamedawnallah commented 11 months ago

Description

Happy New Year everyone 🎄 I'm glad to submit a pull request that addresses the following regression issues caused by Vue js 3 Migration PR #669 :

In addition to resolving the main regression issues, it restores many functionalities implemented in #634.

How Has This Been Tested?

I made sure that all the functionalities work in Global Report V2 as expected in addition to this please check all the test cases passed in the GitHub CI job result: https://github.com/InternetHealthReport/ihr-website/actions/runs/7371266038/job/20058467648

Recordings

https://github.com/InternetHealthReport/ihr-website/assets/69568555/a63361d8-642b-4387-9cba-43d173a288d8

Types of changes

[x] Regression fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

romain-fontugne commented 11 months ago

Thank you both!