InternetHealthReport / ihr-website

Vue.js code for IHR website
https://ihr.iijlab.net/ihr/en
GNU General Public License v3.0
65 stars 122 forks source link

global_report: Handle maximum recursive updates #802

Closed mohamedawnallah closed 6 months ago

mohamedawnallah commented 6 months ago

Description

Hey everyone!

I noticed an issue on the IHR website, specifically on the global report page. When a country is clicked, the site hangs for a while, though it works fine locally in dev mode. After investigating, I found that using filter-fct on the QTable is causing the problem. Removing it solves the issue.

Motivation and Context

Before: You would encounter an error like this (in dev mode locally), which I believe is the main reason why it was stuck: Error Screenshot

After: You will no longer see the error when clicking on a country on the world map.

Types of Changes

Checklist

romain-fontugne commented 6 months ago

thanks, I have noticed the problem but I could find the root cause!

looks good to me

mohamedawnallah commented 6 months ago

@romain-fontugne Thanks! If it is still not working even after deploying this patch, please ping me. I'm willing to debug it more. :)