InternetHealthReport / internet-yellow-pages

A knowledge graph for the Internet
https://iyp.iijlab.net
GNU General Public License v3.0
44 stars 18 forks source link

fix: changed depends_on to type array #30

Closed roopeshsn closed 1 year ago

roopeshsn commented 1 year ago

The depends_on field was changed according to the version 3 compose file structure.

https://docs.docker.com/compose/compose-file/compose-file-v3/#:~:text=Compose%201.27.0%2B.-,Compose%20file%20structure%20and%20examples,-%F0%9F%94%97

29

romain-fontugne commented 1 year ago

thanks for the PR, but we actually need the 'service_completed_successfully' condition. The iyp service should not start before the iyp_loader completed. I guess version 3 has some condition statement for this case?

romain-fontugne commented 1 year ago

I think we can close this one, let me know if we should still work on this?