search

InternetHealthReport / internet-yellow-pages

A knowledge graph for Internet resources
GNU General Public License v3.0
39 stars 16 forks source link

feat: Added a crawler that crawls and push 'AS' number and name from … #51

Closed roopeshsn closed 1 year ago

roopeshsn commented 1 year ago

…emileaben/asnames repo to IYP

46

roopeshsn commented 1 year ago

Looks good to me, apart from the one comment. @roopeshsn How would you like me to handle these small details in the future? I could just make a comment, but make the changes myself and then merge the PR if that's okay with you?

I feel a bit bad requesting "changes" that I could have addressed in the time it took to write the comment :)

I completely understand your perspective and would be more than happy to make the changes myself and then merge the pull request. Also, this process will improve my thought process too over time.

m-appel commented 1 year ago

@roopeshsn

I completely understand your perspective and would be more than happy to make the changes myself and then merge the pull request. Also, this process will improve my thought process too over time.

Ah, maybe we misunderstood each other. I/we will still do the merging in any case, but I will from now on request all changes from you instead of doing them myself (like I did for this commit), is that correct?