InternetHealthReport / internet-yellow-pages

A knowledge graph for Internet resources
GNU General Public License v3.0
39 stars 16 forks source link

Add network and prefixlen properties to Prefix nodes #74

Closed m-appel closed 9 months ago

m-appel commented 9 months ago

We should add two properties to Prefix nodes that contain the network and prefix length explicitly to make some queries (e.g., most specific prefix) easier.

Current properties:

af: 4
prefix: 192.0.2.0/24

Desired properties:

af: 4
network: 192.0.2.0
prefix: 192.0.2.0/24
prefixlen: 24

We add Prefix nodes at multiple places, so this requires some work.

romain-fontugne commented 9 months ago

actually we can figure this out in post-processing, so if these fields are not given we could add them before dumping the database?

m-appel commented 9 months ago

Oh yeah, this makes way more sense. We already fetch all Prefix nodes in the ip2prefix postprocessing script. After seeing the processing time of this script in #80 I think we should probably not create a new script, but just add it to ip2prefix, even though the name gets a bit misleading...