The current functionality within batch_format_link_properties doesn't utilize the returned links when the inplace parameter is set to True. It's more conventionally sound not to return a value if we're already mutating in place.
Changes Made
Removed the return of links from batch_format_link_properties when the inplace parameter is True.
Utilized Optional from the typing module to denote the possible absence of a return value when inplace is set to True.
How Has This Been Tested?
No alterations to the logic's behavior have been made. Testing ensured that the removal of the return value was correctly implemented, specifically when the inplace parameter is True.
Description
The current functionality within
batch_format_link_propertiesdoesn't utilize the returned links when theinplaceparameter is set toTrue. It's more conventionally sound not to return a value if we're already mutating in place.Changes Made
batch_format_link_propertieswhen theinplaceparameter isTrue.Optionalfrom thetypingmodule to denote the possible absence of a return value wheninplaceis set toTrue.How Has This Been Tested?
No alterations to the logic's behavior have been made. Testing ensured that the removal of the return value was correctly implemented, specifically when the
inplaceparameter isTrue.Additional References
Python Optional typing hint: https://docs.python.org/3/library/typing.html#typing.Optional
Types of changes
Checklist: