search

InteropIO / finsemble-seed

Finsemble is a smart desktop platform built on Electron. It allows any type of application to integrate visually and logically with other applications. Applications can sync, link, and share information, even if they weren’t originally designed to.
https://cosaic.io/finsemble/
Other
73 stars 74 forks source link

The fdc3 open function throws the wrong error when the application is not found #772

Closed ColinEberhardt closed 11 months ago

ColinEberhardt commented 2 years ago

When executing window.fdc3.open("ThisAppDoesNotExist"), an error should be thrown with the value OpenError.AppNotFound.

However, OpenError.ErrorOnLaunch is thrown instead.

kriswest commented 2 years ago

Thanks Colin. Duplicate of #766 I think.

Do you know what version the test was run in? This should be fixed in Finsemble 7.3.0 I believe: https://documentation.finsemble.com/docs/welcome/changelog#730-

kriswest commented 2 years ago

@mhmcclung when you're back from vacation could you look at this again? It is resolved for this case: let response = await fdc3.open({appId: "ThisAppDoesNotExist"}) - based on appIdentifier/appId but not this case: let response = await fdc3.open("ThisAppDoesNotExist") - deprecated version based on app name.

Probably just a case of swapping the error on this line: https://github.com/ChartIQ/finsemble-mono/blob/5abf1c1f6f5671a5bcbabe7718b9eb3b69f2a1b4/packages/core/src/platform/services/Interop/modules/resolver.ts#L2700

kriswest commented 11 months ago

Also resolved a long time ago!