Broken since today (grid removal logic was wrong)

[ethanfel]

using the plugin doesn't work anymore.

only a white layer or nothing is generated. I've made a clean install of everything to be sure.

[ethanfel]

with a checkout on 35ad11deffc9dc34d9c8025650d29901598a82fd it's working again

[lambschopping]

Yes, I'm also having problems with this. The checkout fixed it, but seems to roll back a lot of features in the webgui.

[danilw]

Same, just downloaded, image generated and saved in output but not downloaded back to Krita. Will check fix above latter.

[Interpause]

Wait a while. Very weird that Github didn't notify me though. Also weird it still works on my computer.

Are y'all using symlinks or made sure the updated plugin was copied to the pykrita folder? I had to modify the API to accommodate some upstream changes. You might want to try "Restore Defaults" under the Config tab (but backup your prompts first!)

It would also be nice to know which commit is broken, and what operating system you are using.

[Interpause]

I can't reproduce the issue on my Linux machine. I cannot test on my Windows machine until I get home on Saturday, but iirc it was working otherwise I wouuldn't have left it alone.

Tested so far:

• [x] delete outputs, krita_config.yaml and ~/.config/Krita/krita_diff_plugin.ini before starting plugin, followed by backend (test if auto-connect works)
• [ ] cloning repository & setting up from scratch
• [ ] testing above on Windows

[Interpause]

Issue has been reproduced; seems to occur only on fresh document. Occurs regardless of whether there is a selected area or nothing is selected. No idea why it breaks specifically for a fresh document... have to add that to my test checklist...

Actually I got a hypothesis already.

[danilw]

I can't reproduce the issue on my Linux machine.

I setup this Krita plugin on top of exist AUTOMATIC1111/stable-diffusion-webui Also on Linux.

In my case - I see generated output in output directory, even with selected input(img2img), but loading back to Krita not happening.

seems to occur only on fresh document.

I also thought about it, and tried on "create new"(not selecting anything), same but selecting full size (515x512), and opening exist image in Krita and editing it with text2img or img2img - every time result not uploaded back to Krita.

[Interpause]

This is the culprit: https://github.com/interpause/auto-sd-krita/commit/8ec44fd8799ee236c99a9999c2343103dc4cd67b

BTW, it will work if the batch size is larger than 1, or you set it to include the grid in the Config tab (I disabled it by default) :p

I missed it probably cause I left the setting to include the grid on while testing batch size of 1.

[Interpause]

Its fixed: https://github.com/Interpause/auto-sd-krita/commit/5dae4261d9576b3be7648451a810fbf1f968be4f

Please follow https://github.com/Interpause/auto-sd-krita/wiki/Install-Guide#updating to update.

Sorry for taking so long to notice, but personally I blame Github for somehow failing to notify me of this issue.

I probably should look into writing automated tests...

[danilw]

Its fixed:

I can confirm it works now. Thanks!

[ethanfel]

Its fixed: 5dae426

Please follow https://github.com/Interpause/auto-sd-krita/wiki/Install-Guide#updating to update.

Sorry for taking so long to notice, but personally I blame Github for somehow failing to notify me of this issue.

I probably should look into writing automated tests...

thanks for the fix !