search

Interrupt / delverengine

Delver game engine and editor
zlib License
796 stars 77 forks source link

Fix or Remove Custom Java Scripting #267

Open joshuaskelly opened 2 years ago

joshuaskelly commented 2 years ago

Summary

Java scripting is currently broken because it requires the JavaCompiler class which is a JDK feature in Java 8 and not available in the JRE.

Notes

Ship tools.jar

I've tried adding the tools.jar from the JDK libs directory to the JRE libs directory and adding the additional vmarg -Xbootclasspath/a:jre/lib/tools.jar to ensure it can find the library. This works okay from the command line, but does not work from the binaries we ship.

Update Bundled JRE

I've also tried Java 17 now that it has entered an LTS state. It appears that the JavaCompiler is now included with the JRE but how we patch the class path was broken.

PythooonUser commented 2 years ago

Can be closed?

joshuaskelly commented 2 years ago

No. This has not be addressed either way yet. I've temporarily disabled custom scripting because it currently does not work.