search

Interrupt / systemshock

Shockolate - A minimalist and cross platform System Shock source port.
GNU General Public License v3.0
811 stars 66 forks source link

Terrain elevator sound never stops #166

Closed donnierussellii closed 6 years ago

donnierussellii commented 6 years ago

There is a bug with terrain elevators (not inter-level elevators), such that if you push a switch to raise/lower it, then push it again while the sound is still playing, the sound will never stop. This likely is related to what's going on in set_sample_pan_gain().

donnierussellii commented 6 years ago

Fix in my PR #165.

farmboy0 commented 6 years ago

you would be better off putting everything in separate PRs.

donnierussellii commented 6 years ago

Good advice--I've never made a PR before.

Interrupt commented 6 years ago

@farmboy0 is right, in Git it's cheap and easy to make a branch so making a new branch for each fix off of master is usually preferable since it makes reviewing changes easy and bite size. This is fine for now though, just to good to keep in mind in the future.