search

Interrupt / systemshock

Shockolate - A minimalist and cross platform System Shock source port.
GNU General Public License v3.0
806 stars 65 forks source link

[Feature Missing] Fade effects in videos #227

Closed acd2001 closed 5 years ago

acd2001 commented 5 years ago

Some videos are missing of fade effects at the end. Specifically videos of intro and death scene.

Moreover, in the new game screen, the vital signs refresh are very slow (if compared with SSHOCK.EXE).

Interrupt commented 5 years ago

Should all cutscenes fade out at the end?

donnierussellii commented 5 years ago

At the ends of cutscenes as they currently are, there is some audio cut off at the end. I have a PR ready that pauses then fades out to synchronize with the end of audio.

Fading out the win cutscene looks like that's the way it's supposed to be. Looks nice to me.

For the intro cs, it looks like it should pause and fade out the same as the win cs.

And for the death cs, it looks odd to stop the blinking light animation during the pause and fade out. Maybe this should be the exception. But otoh it does seem to end too abruptly.

donnierussellii commented 5 years ago

Addressed pause & fade in my PR #231