search

Interrupt / systemshock

Shockolate - A minimalist and cross platform System Shock source port.
GNU General Public License v3.0
802 stars 62 forks source link

Music: Load the correct midi resources for the music device in use. #319

Closed speachy closed 4 years ago

speachy commented 4 years ago

The weakness of this patch is that switching the music device in game won't trigger a reload of the music resources.

(Personally I think the genmidi resources sound a lot better than the sblaster resources on real GM devices, if only because much greater polyphony is available)

Interrupt commented 4 years ago

It would be nice if switching the music device would reload the music resources, but that could be done in a part two to this work.

Interrupt commented 4 years ago

On Discord talking about this PR someone asked about what happens in the cases where the files wouldn't exist, can we handle some fallback cases for that? We're not exactly sure that all versions of the game resources floating around include both the genmidi and sblaster packs.

speachy commented 4 years ago

(dos) demo, floppy and cdshock all have both sblaster and genmidi resources.

The only one in question is shockmac, and I'd speculate that it would only come with genmidi..

speachy commented 4 years ago

Oh, GoG's version includes both, and the "system shock portable" version does too.