Also newer compilers give a warning (that gets promoted to a compile-time error) on interp.c:216. Fixed it with an explicit conversion
Admittedly, using a std::unique_ptr is a bit overkill here because CreateFrameBuffer is only called once in the entire code base, but I've decided to stay future-proof just in case.
Also, maybe project's CMAKE_CXX_STANDARD could be bumped to at least 14-17? I see no reason to keep it as low as 11, but ofc there's also an argument of "if it ain't broke don't fix it"...
Also newer compilers give a warning (that gets promoted to a compile-time error) on
interp.c:216. Fixed it with an explicit conversionAdmittedly, using a
std::unique_ptris a bit overkill here becauseCreateFrameBufferis only called once in the entire code base, but I've decided to stay future-proof just in case.Also, maybe project's
CMAKE_CXX_STANDARDcould be bumped to at least 14-17? I see no reason to keep it as low as 11, but ofc there's also an argument of "if it ain't broke don't fix it"...