search

IntersectMBO / bech32

Haskell implementation of the Bech32 address format (BIP 0173).
Apache License 2.0
44 stars 13 forks source link

Test failure on Human-Readable Prefixes #27

Closed newhoggy closed 3 years ago

newhoggy commented 3 years ago

This was reproduced on MacOS:

Codec.Binary.Bech32.TH
  Quasi-Quotations
    Human-Readable Prefixes
      Parsing valid human-readable prefixes should succeed.
        "!"
        "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
        "addr"
      Parsing invalid human-readable prefixes should fail.
        "" FAILED [1]
        "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" FAILED [2]
        "  " FAILED [3]
        "\DEL\DEL" FAILED [4]
newhoggy commented 3 years ago

Given that there is a potential platform specific failure, I'd like to modify the Github Actions build to do a Matrix build over MacOS and Windows.

newhoggy commented 3 years ago

Turns out it's not a platform problem, but a GHC version problem. This PR shows the code compiles against Linux, MacOS and Windows when using ghc-8.6.5, but it doesn't not compile against ghc-8.10.2

rvl commented 3 years ago

So it works on ghc-8.6.5 (all platforms) and fails on ghc-8.10.2 (all platforms). Did you mean it compiles but tests fail, or does it not compile at all for ghc-8.10.2?

If the latter, is this simply due to -Werror?

If the former, is the failure actually due to GHC itself, or is it because the cabal solver has selected a different set of package versions (and perhaps a quickcheck generator change has caused this test failure, or something like that).

rvl commented 3 years ago

No response, closing.