search

IntersectMBO / cardano-api

Cardano API
Apache License 2.0
22 stars 20 forks source link

Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEraAlonzo' as input #613

Closed koslambrou closed 3 weeks ago

koslambrou commented 1 month ago

Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEraAlonzo' as input

Changelog

- description: |
    Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEraAlonzo' as input
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

koslambrou commented 1 month ago

The build is failing because the GHC-8.10 build tells me to remove import Control.Monad (forM_), but that import is required for GHC >= 9. Should I solve this with something like __GLASGOW_HASKELL__ >= 9?

carbolymer commented 3 weeks ago

@koslambrou

Should I solve this with something like __GLASGOW_HASKELL__ >= 9?

No, we're aiming to avoid CPP as much as possible. Can you try to just import Control.Monad without listing imported functions? If it does not help, can you make that import qualified instead?

carbolymer commented 3 weeks ago

Can you rebase the PR onto latest main?