IntersectMBO / cardano-api

Cardano API
Apache License 2.0
22 stars 20 forks source link

Keep Coin as the user-facing name of functions #614

Closed smelc closed 1 month ago

smelc commented 1 month ago

Changelog

- description: |
    Add `Lovelace` as a type synonym to `Coin`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

  1. Only adds a type synonym
  2. Removes a private function
  3. New type synonym is correctly exported

Checklist

smelc commented 1 month ago

Thanks @carbolymer for the swift review!

cc @Jimbo4350