IntersectMBO / cardano-api

Cardano API
Apache License 2.0
26 stars 23 forks source link

638-Allow next leadership-schedule at 4k/f #639

Closed AndrewWestberg closed 2 months ago

AndrewWestberg commented 2 months ago

Changelog

- description: |
    Allow next leadership-schedule at 4k/f
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes 638

How to trust this PR

It's a 1 number change from 3->4. It's trustworthy.

Checklist

carbolymer commented 2 months ago

Reference for 4k/f value in leadership selection in Conway: https://ouroboros-consensus.cardano.intersectmbo.org/docs/for-developers/Glossary#epoch-structure

carbolymer commented 2 months ago

@AndrewWestberg can you reformat your changes with:

./scripts/devshell/prettify cardano-api/internal/Cardano/Api/LedgerState.hs
AndrewWestberg commented 2 months ago

@AndrewWestberg can you reformat your changes with:

./scripts/devshell/prettify cardano-api/internal/Cardano/Api/LedgerState.hs

This is completed.

Jimbo4350 commented 2 months ago

Reference for 4k/f value in leadership selection in Conway: https://ouroboros-consensus.cardano.intersectmbo.org/docs/for-developers/Glossary#epoch-structure

@AndrewWestberg can you include a comment pointing to this and any other background regarding the 4k/f value.

AndrewWestberg commented 2 months ago

Reference for 4k/f value in leadership selection in Conway: https://ouroboros-consensus.cardano.intersectmbo.org/docs/for-developers/Glossary#epoch-structure

@AndrewWestberg can you include a comment pointing to this and any other background regarding the 4k/f value.

This is resolved.