search

IntersectMBO / cardano-base

Code used throughout the Cardano eco-system
Apache License 2.0
95 stars 41 forks source link

Fix incorrect lower bound on io-classes and bump up the version. #426

Closed lehins closed 1 year ago

lehins commented 1 year ago

Lower bound was missing for io-classes and flakes was outdated, which resulted an older version being picked, which in turn resulted in a build error.

This PR fixes this problem

src/Test/Crypto/Util.hs:133:1: error:
    Could not find module ‘Control.Concurrent.Class.MonadMVar’
    Perhaps you meant
      Control.Concurrent.Class.MonadSTM (from io-classes-1.0.0.1)
      Control.Concurrent.Class.MonadSTM.TVar (from io-classes-1.0.0.1)
      Control.Concurrent.Class.MonadSTM.TMVar (from io-classes-1.0.0.1)
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
    |
133 | import Control.Concurrent.Class.MonadMVar (MVar, withMVar, newMVar)
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build cardano-crypto-tests-2.2.0.0.
michaelpj commented 1 year ago

BTW Hydra CI seems to be showing up a genuine compilation failure in mempool-bench. Is the GHA CI building without benchmarks enabled?

lehins commented 1 year ago

Is the GHA CI building without benchmarks enabled?

Yeah, sounds like it. @jorisdral just pointed out the same: https://github.com/input-output-hk/cardano-base/pull/418#issuecomment-1651914017

lehins commented 1 year ago

Opened a ticket about benchmarks: https://github.com/input-output-hk/cardano-base/issues/427

michaelpj commented 1 year ago

I'm just gonna fix it