IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
43 stars 15 forks source link

Update cardano-api-8.39.0.0 #616

Closed carbolymer closed 8 months ago

carbolymer commented 8 months ago

Changelog

- description: |
    Update [cardano-api-8.39.0.0](https://github.com/IntersectMBO/cardano-api/blob/main/cardano-api/CHANGELOG.md#83900)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR contains indices bump and redundant imports removal, because of how cardano-api exports things now.

Checklist

carbolymer commented 8 months ago

Hydra windows build is failing because of haskell.nix + blst on windows issues: https://input-output-rnd.slack.com/archives/CG1FBSDMM/p1708462370264619

palas commented 8 months ago

Sorry, it seems I did the same exact thing you did in https://github.com/IntersectMBO/cardano-cli/pull/558 (really wanted to get it merged). I misunderstood something and it didn't occur to me to check whether the imports had been fixed in another PR until after doing it myself 🤦. Anyway, the way you fixed cardano-cli/src/Cardano/CLI/Pretty.hs is much nicer, I didn't know you could do that.

carbolymer commented 8 months ago

@palas no worries, thanks for doing that! I've just updated the description of #558.

carbolymer commented 8 months ago

Superceded by https://github.com/IntersectMBO/cardano-cli/pull/558