search

IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
39 stars 14 forks source link

create-testnet-data: fix computation of not-delegated amount #638

Closed smelc closed 6 months ago

smelc commented 6 months ago

Changelog

- description: |
    create-testnet-data: fixes that amount of delegated coins was incorrect
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes https://github.com/IntersectMBO/cardano-cli/issues/631

How to trust this PR

  1. Run the new test (cabal test cardano-cli-golden --test-options '-p "/golden create testnet data deleg non deleg/"') before the fix, witness the test fails
  2. Run the test on the head of this PR. Enjoy the passing test.
  3. Tested on cardano-node locally
  4. Tested CI on cardano-node: https://github.com/IntersectMBO/cardano-node/pull/5712

Checklist