[ ] Code & Test review (as per Acceptance Criteria)
[ ] There is documentation and/or examples for the new functionality (usage/response)
[ ] Log/record changes on Vnext (or similar depending on what we adopt)
[ ] Ticket number(s) included in PR description
[ ] All Acceptance Criteria met and covered by dev/unit/property/integration tests
[ ] System/E2E automated tests + System Test Engineer Owner Sign-off
NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).
IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.
Sign-off
[ ] Product Owner
[ ] Dev Owner
[ ] System Test Engineer Owner
Related PRs
PR # here
Acceptance Criteria
Acceptance Criteria & User Stories define here (or in a separate file (linked here) for a big feature)
What
Why
Personas
Definition of Done (DoD)
Sign-off
Related PRs
Acceptance Criteria
Acceptance Criteria & User Stories define here (or in a separate file (linked here) for a big feature)
Example - https://github.com/input-output-hk/cardano-node/issues/4453