IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
43 stars 15 forks source link

Switch to using cardano-git-rev from cardano-base repo (backport) #679

Closed newhoggy closed 3 months ago

newhoggy commented 7 months ago

The version of cardano-git-rev in the cardano-base repo is a TH splice instead of a function, so it will always be executed/evaluated at the call site.

Changelog

- description: |
    Switch to using cardano-git-rev from cardano-base repo (backport)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Back porting https://github.com/IntersectMBO/cardano-cli/pull/647

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

carbolymer commented 7 months ago

Node got updated with newer cli with newer cardano-cli with newer cardano-git-rev. Is this still needed?

github-actions[bot] commented 5 months ago

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] commented 3 months ago

This issue was closed because it has been stalled for 60 days with no activity.