IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
43 stars 15 forks source link

Throw an error on identical action-ids in votes of one voter #681

Closed smelc closed 7 months ago

smelc commented 7 months ago

Changelog

- description: |
    transaction build{,-raw}: throw an error on identical action-ids in votes files
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes https://github.com/IntersectMBO/cardano-cli/issues/662

How to trust this PR

Checklist

smelc commented 7 months ago

Question to reviewers:

carbolymer commented 7 months ago

Question to reviewers:

Yes. Can be done in a separate PR.

smelc commented 7 months ago

PR to move mergeVotingProcedures to cardano-api is at https://github.com/IntersectMBO/cardano-api/pull/498