search

IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
41 stars 15 forks source link

`calculate-min-fee` no longer working for Shelley-era transactions #700

Open mkoura opened 7 months ago

mkoura commented 7 months ago

Description

Building basic Shelley-era transactions using build-raw is still supported (e.g. for bootstrapping testnets). However calculate-min-fee command stopped working for Shelley-era tx after recent fee calculation refactoring. The command fails with

Command failed: transaction calculate-min-fee Error: Error while converting protocol parameters: Missing parameter: decentralization

Steps to Reproduce

  1. Try to calculate fee for Shelley-era tx

    cardano-cli shelley transaction calculate-min-fee --testnet-magic 42 --protocol-params-file pparams.json --tx-body-file estimate_tx.body --reference-script-size 0 --witness-count 1

  2. See the error

Additional Context

Tested in Babbage era with cardano-cli 8.22.0.0. Tx body and pparams files: issue_calc_min_fee.tar.gz

Jimbo4350 commented 7 months ago

This is not a conway-era-integration-bug. We need to deprecate these old commands as nobody is likely using them.

gitmachtl commented 6 months ago

Building basic Shelley-era transactions using build-raw is still supported @mkoura

We need to deprecate these old commands as nobody is likely using them. @Jimbo4350

What exactly do you mean with "we need to deprecate these old commands?" Using build-raw and calculate-min-fee all the time, the SPO scripts for SPOs are built on that! Do you mean we cannot use it for testnets in the bootstrap phase until we get to a later era?

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] commented 1 month ago

This issue was closed because it has been stalled for 120 days with no activity. Remove stale label or comment or this will be closed in 60 days.

gitmachtl commented 1 month ago

keep alive

carbolymer commented 1 month ago

@Jimbo4350 I think this needs your input here

carbolymer commented 1 month ago

@gitmachtl what's your use case for running CLI commands in testnets in older eras? Would it be feasible just hardfork to the target era, at the very beginning, like it's done in cardano-testnet?

gitmachtl commented 1 month ago

i would say yes. as long as we don't have any testnets anymore in the future that are staying a longer period in shelley era, it can be removed for shelley era.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.