IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
43 stars 15 forks source link

Fix Conway era protocol parameters update #702

Closed ArturWieczorek closed 7 months ago

ArturWieczorek commented 7 months ago

Changelog

- description: |
    Fix common protocol parameters ordering and Conway era protocol parameters update
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes https://github.com/IntersectMBO/cardano-cli/issues/701

This is Conway CDDL:

protocol_param_update =
  { ? 0:  coin                   ; minfee A
  , ? 1:  coin                   ; minfee B
  , ? 2:  uint                   ; max block body size
  , ? 3:  uint                   ; max transaction size
  , ? 4:  uint                   ; max block header size
  , ? 5:  coin                   ; key deposit
  , ? 6:  coin                   ; pool deposit
  , ? 7:  epoch                  ; maximum epoch
  , ? 8:  uint                   ; n_opt: desired number of stake pools
  , ? 9:  nonnegative_interval   ; pool pledge influence
  , ? 10: unit_interval          ; expansion rate
  , ? 11: unit_interval          ; treasury growth rate
  , ? 16: coin                   ; min pool cost
  , ? 17: coin                   ; ada per utxo byte
  , ? 18: costmdls               ; cost models for script languages
  , ? 19: ex_unit_prices         ; execution costs
  , ? 20: ex_units               ; max tx ex units
  , ? 21: ex_units               ; max block ex units
  , ? 22: uint                   ; max value size
  , ? 23: uint                   ; collateral percentage
  , ? 24: uint                   ; max collateral inputs
  , ? 25: pool_voting_thresholds ; pool voting thresholds
  , ? 26: drep_voting_thresholds ; DRep voting thresholds
  , ? 27: uint                   ; min committee size
  , ? 28: epoch                  ; committee term limit
  , ? 29: epoch                  ; governance action validity period
  , ? 30: coin                   ; governance action deposit
  , ? 31: coin                   ; DRep deposit
  , ? 32: epoch                  ; DRep inactivity period
  , ? 33: nonnegative_interval   ; MinFee RefScriptCostPerByte
  }

It looks that:

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist