IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
39 stars 14 forks source link

Enable manual specification of execution units for plutus voting and proposing scripts #744

Closed Jimbo4350 closed 4 months ago

Jimbo4350 commented 4 months ago

Changelog

- description: |
    Enable manual specification of execution units for plutus voting and proposing scripts
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

Jimbo4350 commented 4 months ago

Looks good 👍. One thing to consider is if we want --vote-execution-units to be optional. Making it optional would make it retro-compatible and more flexible.

It has to be manually specified in build-estimate. Making it optional would make it impossible to make a valid tx with a plutus voting script.