search

IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
37 stars 13 forks source link

Description field in SCRIPT based registration certificate says "DRep Key Registration Certificate" #756

Open CarlosLopezDeLara opened 3 months ago

CarlosLopezDeLara commented 3 months ago

Description

When generating a script based DRep registration certificate, the "Description" field in the text envelope still shows "DRep Key Registration Certificate". 

cardano-cli conway governance drep registration-certificate \
  --drep-script-hash drep-multisig.hash \
  --key-reg-deposit-amt "$drepDeposit" \
  --out-file drep-multisig-reg.cert

cat drep-multisig-reg.cert
{
    "type": "CertificateConway",
    "description": "DRep Key Registration Certificate",
    "cborHex": "84108201581c1d8fe9486b5fb282287568f04445c8f4d6cddf76ce2df527fd7debbe1a001e8480f6"
}

Provide a brief summary of the issue. If possible, include the expected result and the observed result.

Steps to Reproduce

  1. Create a multisignature Native script
  2. Get its hash
  3. Generate a DRep registration certificate using --drep-script-hash option.
  4. Verify that the certificate's description says DRep Key Registration Certificate. ...

Additional Context

Possible Solution

We can generalize the description to say "DRep Registration Certificate" or include some logic to differentiate between key and script.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.