search

IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
37 stars 13 forks source link

query protocol-parameters: use ledger JSON encoding, not API one #758

Closed smelc closed 3 months ago

smelc commented 3 months ago

Changelog

- description: |
    query protocol-parameters: use ledger JSON encoding, not API one
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Checklist

smelc commented 3 months ago

Work happening at https://github.com/IntersectMBO/cardano-cli/commits/smelc/8.22.0.0-backport-write-protocol-parameters-use-ledger-encoding/

I will bring the commits to this PR when I'm done. I need to work on 8.22.0.0 to more easily test that with cardano-node master.

carbolymer commented 3 months ago

@smelc check afterwards with @mkoura if it's not breaking cardano-node-tests too.

smelc commented 3 months ago

@gitmachtl> can you give this PR a new round of testing?

gitmachtl commented 3 months ago

@gitmachtl> can you give this PR a new round of testing?

@smelc yea, will do it over the weekend, thx.

gitmachtl commented 3 months ago

@gitmachtl> can you give this PR a new round of testing?

@smelc looking good. did test the min-fee calculation, min-utxo calculation, made transactions via build-raw and ran the new build-estimate command with the new protocol-parameter version. 👍 but i only tested in conway era. have to redo it also in babbage era.

gitmachtl commented 3 months ago

@smelc ok, babbage era also looks good 👍

smelc commented 3 months ago

Thanks @gitmachtl for the feedback :pray:

gitmachtl commented 3 months ago

LGTM! Feel free to merge as long as @gitmachtl is happy.

@Jimbo4350 i am happy 😄