Closed smelc closed 3 months ago
Work happening at https://github.com/IntersectMBO/cardano-cli/commits/smelc/8.22.0.0-backport-write-protocol-parameters-use-ledger-encoding/
I will bring the commits to this PR when I'm done. I need to work on 8.22.0.0 to more easily test that with cardano-node
master
.
@smelc check afterwards with @mkoura if it's not breaking cardano-node-tests too.
@gitmachtl> can you give this PR a new round of testing?
@gitmachtl> can you give this PR a new round of testing?
@smelc yea, will do it over the weekend, thx.
@gitmachtl> can you give this PR a new round of testing?
@smelc looking good. did test the min-fee calculation, min-utxo calculation, made transactions via build-raw and ran the new build-estimate command with the new protocol-parameter version. đ but i only tested in conway era. have to redo it also in babbage era.
@smelc ok, babbage era also looks good đ
Thanks @gitmachtl for the feedback :pray:
LGTM! Feel free to merge as long as @gitmachtl is happy.
@Jimbo4350 i am happy đ
Changelog
Context
How to trust this PR
cardano-node
's tests ran on this PR: https://github.com/IntersectMBO/cardano-node/pull/5839cardano-node
's PR: https://github.com/IntersectMBO/cardano-node/pull/5839/filesChecklist