IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
37 stars 13 forks source link

Make `--fee` mandatory in `transaction build-raw` #768

Closed carbolymer closed 3 months ago

carbolymer commented 3 months ago

Changelog

- description: |
    Make `--fee` mandatory in `transaction build-raw`. Remove `TxCmdTxFeeValidationError` type.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Seems that fees should be mandatory for eras >= Shelley, but the CLI interface wasn't saying so and was defaulting to 0.

Checklist